Split erldns_resolver #259
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also move RRSIG records from being refused to being throttled.
NelsonVides
added
the
enhancement
Pull Request Test Coverage Report for Build 16142124750Details
💛 - Coveralls |
DXTimer
reviewed
Jul 8, 2025
| erldns_handler:call_handlers( | ||
| Message, QLabels, Qtype, MatchedRecords | ||
| ), | ||
| erldns_dnssec:maybe_sign_rrset(Message, HandlerRecords, Zone); |
Contributor
There was a problem hiding this comment.
We are no longer signing on the fly unless I am missing something. Is that intentional?
Contributor
Author
There was a problem hiding this comment.
This code was there before and I was also assuming it was a left-over from the days signatures used to be on the fly 🤔 In any case, if there's anything missing signatures, it should be verified by the dnssec pipe handler after the resolver put all the records.
Contributor
Author
There was a problem hiding this comment.
Which makes me realise, this function is not used anymore! Will remove it from here.
DXTimer
approved these changes
Jul 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split dnssec, sorter, and recursion flags, from erldns_resolver.
Also move RRSIG records from being refused to being throttled.