Skip to content

Conversation

@NelsonVides
Copy link
Contributor

@NelsonVides NelsonVides commented Jul 8, 2025

Uses persistent_term instead of ETS tables, and callbacks are preallocated instead of resolved at runtime again and again. Same optimisations than zone codecs or pipelines had.

This will be useful when reworking specially the resolver, as currently so much code internal to the handlers is scattered there and in the dnssec module. It also clearly defines a behaviour for this module, as callbacks were not specified.

@NelsonVides NelsonVides self-assigned this Jul 8, 2025
@NelsonVides NelsonVides added the enhancement New feature, enhancement or code changes, not related to defects label Jul 8, 2025
@coveralls
Copy link

coveralls commented Jul 8, 2025

Pull Request Test Coverage Report for Build 16138661929

Details

  • 45 of 61 (73.77%) changed or added relevant lines in 3 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+1.3%) to 82.121%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/erldns_handler.erl 38 54 70.37%
Files with Coverage Reduction New Missed Lines %
src/erldns_handler.erl 1 69.49%
Totals Coverage Status
Change from base Build 16137778602: 1.3%
Covered Lines: 1208
Relevant Lines: 1471

💛 - Coveralls

@NelsonVides NelsonVides merged commit 161cbc7 into main Jul 8, 2025
7 checks passed
@NelsonVides NelsonVides deleted the erldns_handler branch July 8, 2025 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature, enhancement or code changes, not related to defects

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants