Skip to content

Conversation

@NelsonVides
Copy link
Contributor

Note that the directory was not wildcard matching children dirs and therefore there were many modules that were not being linted.

Fixes for the ignored errors will come with later PRs.

Note that the directory was not wildcard matching children dirs and
therefore there were many modules that were not being linted.
@NelsonVides NelsonVides requested review from DXTimer and weppos July 7, 2025 15:07
@NelsonVides NelsonVides self-assigned this Jul 7, 2025
@NelsonVides NelsonVides added the enhancement New feature, enhancement or code changes, not related to defects label Jul 7, 2025
@coveralls
Copy link

coveralls commented Jul 7, 2025

Pull Request Test Coverage Report for Build 16137114746

Details

  • 8 of 24 (33.33%) changed or added relevant lines in 7 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.5%) to 80.623%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/erldns_handler.erl 0 1 0.0%
src/listeners/erldns_listeners.erl 1 2 50.0%
src/zones/erldns_zone_codec.erl 0 1 0.0%
src/zones/erldns_zone_encoder.erl 0 2 0.0%
src/listeners/erldns_proto_tcp.erl 5 8 62.5%
src/listeners/erldns_proto_udp.erl 2 6 33.33%
src/zones/erldns_zone_loader.erl 0 4 0.0%
Files with Coverage Reduction New Missed Lines %
src/zones/erldns_zone_encoder.erl 2 67.65%
Totals Coverage Status
Change from base Build 16120685046: -0.5%
Covered Lines: 1165
Relevant Lines: 1445

💛 - Coveralls

@NelsonVides NelsonVides requested a review from DXTimer July 7, 2025 17:04
@NelsonVides NelsonVides merged commit 715d3d6 into main Jul 8, 2025
7 checks passed
@NelsonVides NelsonVides deleted the expand_linter branch July 8, 2025 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature, enhancement or code changes, not related to defects

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants