Skip to content

Add physical units for BH mdot? #240

@GrantPDonnelly

Description

@GrantPDonnelly

In front_ends/arepo2pd.py, we calculate BH luminosities from mdot. Currently, it looks like

mdot = data.ds.arr(mdot, "code_mass/code_time")

But this gives a luminosity 10x too high. It can be corrected if I instead do:

mdot = data.ds.arr(mdot, "Msun/yr")

Is there a good reason to not use physical units here? Maybe to keep it as general as possible? I know I had the correct luminosity before, so I wonder if I accidentally reversed this line before a commit...

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions