Privatize docsrs cfg flag, use doc_cfg in CI.#214
Merged
Conversation
Fixes a docs.rs build failure by following the same approach used in rustls, removing `doc_auto_cfg` and privatizing the docsrs cfg flag. ``` [INFO] [stderr] Documenting instant-acme v0.8.3 (/opt/rustwide/workdir) [INFO] [stderr] error[E0557]: feature has been removed [INFO] [stderr] --> src/lib.rs:5:38 [INFO] [stderr] | [INFO] [stderr] 5 | #![cfg_attr(docsrs, feature(doc_cfg, doc_auto_cfg))] [INFO] [stderr] | ^^^^^^^^^^^^ feature has been removed [INFO] [stderr] | [INFO] [stderr] = note: removed in CURRENT_RUSTC_VERSION; see <rust-lang/rust#138907> for more information [INFO] [stderr] = note: merged into `doc_cfg` [INFO] [stderr] [INFO] [stderr] error: Compilation failed, aborting rustdoc ```
This in turn requires using nightly.
djc
approved these changes
Nov 20, 2025
Owner
djc
left a comment
djc
left a comment
There was a problem hiding this comment.
Thanks! Want to put in a version bump?
Collaborator
Author
Done. Would you mind publishing to crates.io post-merge? I don't think I have perms. |
Owner
|
Published 0.8.4. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a docs.rs build failure by following the same approach used in rustls, removing
doc_auto_cfgand privatizing the docsrs cfg flag. Also switches CI to build docs w/doc_cfgenabled.