feat: add create_from_key for accounts with user-provided keys#208
Merged
feat: add create_from_key for accounts with user-provided keys#208
Conversation
ptrus
force-pushed
the
ptrus/feature/create-from-key
branch
from
dd94629 to
a24acb9
Compare
Allows creating ACME accounts using externally managed keys, instead of being limited to loading existing ones or registering with library-generated keys.
ptrus
force-pushed
the
ptrus/feature/create-from-key
branch
from
a24acb9 to
08469e0
Compare
djc
approved these changes
Nov 4, 2025
cpu
reviewed
Nov 4, 2025
Collaborator
cpu
left a comment
cpu
left a comment
There was a problem hiding this comment.
Generally seems like a reasonable idea. Thanks for including test coverage.
One question about the new API that might need a bit more refactoring to accommodate if it's viable.
cpu
approved these changes
Nov 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, Thanks for the great library!
I needed a way to create ACME accounts using externally managed keys, so this PR adds that functionality. I made the change backwards compatible (i.e., introduced a new public method without changing the existing ones).
Allows creating ACME accounts using externally managed keys, instead of being limited to loading existing ones or registering with library-generated keys.
Please let me know if anything should be updated or improved.