Skip to content

Skip serializing replaces field if None#136

Merged
djc merged 1 commit intodjc:mainfrom
styris-ame:skip-none-replaces-serialization
Jul 14, 2025
Merged

Skip serializing replaces field if None#136
djc merged 1 commit intodjc:mainfrom
styris-ame:skip-none-replaces-serialization

Conversation

@styris-ame
Copy link
Contributor

@styris-ame styris-ame commented Jul 14, 2025

Fixes #135

@djc djc merged commit b3da4d0 into djc:main Jul 14, 2025
12 checks passed
@djc djc mentioned this pull request Jul 14, 2025
@djc
Copy link
Owner

djc commented Jul 14, 2025

Thanks! Preparing release in #137.

@cpu
Copy link
Collaborator

cpu commented Jul 14, 2025

Are there other places we should be giving the same treatment? E.g. in #135 @styris-ame said:

Now when replaces is None, it is simply not serialized, solving the issue with ZeroSSL:
{"identifiers":[{"type":"dns","value":"zerossl-test.styris.net"}],"profile":null}

Should profile be serialized when null?

@cpu
Copy link
Collaborator

cpu commented Jul 14, 2025

Should profile be serialized when null?

I did a quick pass and this seems to be the only other Optional field without the annotation in a Serializable type we send to a peer. I'll open a quick fix PR in a sec.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ZeroSSL failure due to null replaces field

3 participants