account: support default client w/ custom root CA#131
Merged
Conversation
cpu
commented
Jul 4, 2025
Closed
djc
reviewed
Jul 4, 2025
Owner
djc
left a comment
djc
left a comment
There was a problem hiding this comment.
I like this! cc @the-wondersmith would this address your use case?
cpu
changed the title
Owner
|
(Also needs a rebase.) |
djc
approved these changes
Jul 7, 2025
djc
approved these changes
Jul 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Possible alternative to #128
Fixes #127
Adjusting the Pebble tests to benefit from this constructor will take some additional work. We want to be able to store a pre-configured client in the env to use outside of
Accountactions (e.g. inEnvironment::issuer_roots()to fetch issuer roots).