Conversation
Closed
cpu
approved these changes
Jun 27, 2025
djc
commented
Jun 27, 2025
| impl RetryState { | ||
| async fn wait(&mut self, after: Option<SystemTime>) -> ControlFlow<(), ()> { | ||
| if self.tries == 0 { | ||
| if self.start.elapsed() > self.timeout { |
Owner
Author
There was a problem hiding this comment.
Uhh, not sure how this interaction will work? Seems like a strong chance the server might yield a Retry-After of more than the timeout set here, which means we'll only ever try once...
Contributor
There was a problem hiding this comment.
One option is to preemptively end the retry if the next iteration would exceed the timeout. This is how acme4j does it.
On the other hand, if the retry cause can be resolved inbetween (e.g. load of the server), one retry at the end of the timebox might be helpful.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.