Django Debug Toolbar renders poorly

[pauloxnet]

Running the project locally for development, I noticed that Django Debug Toolbar (DDT) renders poorly.

I compared the rendered bar on a Django project created with startproject and there are several differences in rendering as shown in the difference of the two screenshots.

DDT in current repository

DDT in a new demo project

I ask you to verify that also in your local environments the bar is rendered badly, in order to confirm the bug and understand if a fix is ​​needed in the local code or if we need to open an issue in the DDT repository.

[marksweb]

Confirmed.

I think this is coming from height: 46px; for form buttons in output.css.

[pauloxnet]

Confirmed.

I think this is coming from height: 46px; for form buttons in output.css.

Thanks.

I also see some differences with text and colors.

[bmispelon]

Indeed, this happens because the toolbar is inheriting some of our global styles. I don't see a general way around that, but I've opened a PR that at least fixes the button sizing: #2041.

[bmispelon]

Thanks to the work of the debug toolbar's maintainers, this will be fixed upstream once django-commons/django-debug-toolbar#2130 is merged/released. 🎉

[sabderemane]

Sounds like the PR is merged, @bmispelon what is missing to do for this one to close it?

[bmispelon]

Sounds like the PR is merged, @bmispelon what is missing to do for this one to close it?

I was waiting for a release to be made that includes the fix, but I'm also ok to close this now under the assumption that a release will come sooner or later.

[adamzap]

@bmispelon I believe it was in v5.2.0, which we got in #2065. See the bottom of the changelog: https://github.com/django-commons/django-debug-toolbar/releases/tag/5.2.0.