-
Notifications
You must be signed in to change notification settings - Fork 809
Add support for RP-Initiated Registration #1571
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
fb2e149
to
f7f1e97
Compare
@lullis could you please rebase this PR? |
f7f1e97
to
1047e95
Compare
@dopry sorry, I haven't seen the notification for this message. I rebased it now, let me know if you need anything else. |
@lullis at a glance this looks pretty good and follows my understanding of prompt=create. I'll try to give it a proper review next week. ping me if you don't hear from me. If anyone else is interested in this feature in the meantime, please feel free to test it and provide feedback. |
1047e95
to
b8c3264
Compare
@dopry you asked me to ping you about this. Did you get a chance to look at it? |
yep and it's still on my radar. As soon as we get the repo transferred out of jazzband i'm going to get codecov fixed merge the other PRs in our backlog and get to this one. |
@lullis could you resolve the conflicts and rebase this one when you get a chance? |
e85b5a4
to
83aad34
Compare
By adding a `prompt=create` parameter to the authorization request, the user is redirected to the OP's registration point where they can create an account, and on successful registration the user is then redirected back to the authorization view with prompt=login Closes django-oauth#1546
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
83aad34
to
8841c0b
Compare
Fixes #1546
Description of the Change
By adding a
prompt=create
parameter to the authorization request, the user is redirected to the OP's registration point where they can create an account, and on successful registration the user is then redirected back to the authorization view with prompt=loginChecklist
CHANGELOG.md
updated (only for user relevant changes)AUTHORS