DEV: use modifyClass for homepage behavior instead of setDefaultHomepage#46
Open
awesomerobot wants to merge 2 commits intomainfrom
Open
DEV: use modifyClass for homepage behavior instead of setDefaultHomepage#46awesomerobot wants to merge 2 commits intomainfrom
awesomerobot wants to merge 2 commits intomainfrom
Conversation
OsamaSayegh
approved these changes
Apr 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We had to revert a core commit, discourse/discourse@a53910e, because it added a call to
discovery.${defaultHomepage()}— which in the case of this theme causeddiscourse-ai/ai-bot/conversationsto becomediscovery.discourse-ai/ai-bot/conversationsThe solution used here in the theme was kind of a hack anyway, so moving to
modifyClassoverrides the method and avoids this issue, as well as a previous issue with a circular reference. Ideally at some point we can update core to allow for arbitrary routes as the homepage and remove this override.So after merging this, we can go back and re-apply that core change.
I also hid the "back to forum" button in the CSS, which is irrelevant here.