Skip to content

Conversation

catplvsplus
Copy link
Contributor

Please describe the changes this PR makes and why it should be merged:
Adds env, execArgv, argv to worker thread creation options. This allows the ShardingManagerOptions#execArgv, ShardingManagerOptions#shardArgs and Shard#env to be used not only by the child-process based shards.

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

@catplvsplus catplvsplus requested a review from a team as a code owner August 4, 2024 11:57
Copy link

vercel bot commented Aug 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) Visit Preview Aug 20, 2024 11:26am
discord-js-guide ⬜️ Ignored (Inspect) Visit Preview Aug 20, 2024 11:26am

@catplvsplus catplvsplus changed the title fix: add env, execArgv, and argv for worker-based shards fix(Shard): add env, execArgv, and argv for worker-based shards Aug 4, 2024
almeidx
almeidx previously requested changes Aug 4, 2024
Copy link
Member

@almeidx almeidx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These doc comments need updating

/**
* Arguments for the shard's process (only when {@link ShardingManager#mode} is `process`)
* @type {string[]}
*/
this.args = manager.shardArgs ?? [];
/**
* Arguments for the shard's process executable (only when {@link ShardingManager#mode} is `process`)
* @type {string[]}
*/
this.execArgv = manager.execArgv;

@almeidx almeidx dismissed their stale review August 4, 2024 12:33

Resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

6 participants