Skip to content
This repository was archived by the owner on Feb 20, 2026. It is now read-only.

Allow library to be initialized with a reader#9

Open
elynnyap wants to merge 0 commit intodigitalcrab:masterfrom
LiveRamp:master
Open

Allow library to be initialized with a reader#9
elynnyap wants to merge 0 commit intodigitalcrab:masterfrom
LiveRamp:master

Conversation

@elynnyap
Copy link
Copy Markdown

  • Add an option to initialize the browscap library with a Reader, instead of strictly from an .ini file. (We needed this option as we used an embedded asset for browscap.ini via go-bindata.)
  • Add test for initializing from Reader.
  • Improve current tests, which rely on a particular order of execution in order to pass; namely, they assume that the library has been initialized first. This change ensures that the tests still pass when run individually.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant