Treat both 2XX and 3XX responses as successful.

[alexmingoia]

The 303 See Other response is often used to direct clients to another page after successfully creating a new resource, and such behavior is encouraged by web standards.

Thanks for this module, it's very useful. I'm using it to develop a web application.

[greizgh]

You could also add a test case checking for commit on redirection:

#[tokio::test]
async fn commit_on_redirection() {
    let (_db, pool, response) = build_app(|mut tx: Tx| async move {
        let (_, _) = insert_user(&mut tx, 1, "john redirect").await;
        http::StatusCode::SEE_OTHER
    })
    .await;

    assert!(response.status.is_redirection());

    let users: Vec<(i32, String)> = sqlx::query_as("SELECT * FROM users")
        .fetch_all(&pool)
        .await
        .unwrap();
    assert_eq!(users, vec![(1, "john redirect".to_string())]);
}

[greizgh]

It might be safer to check that there was no error:

Suggested change

	if res.status().is_success() || res.status().is_redirection() {
	if !(res.status().is_server_error() || res.status().is_client_error()) {

[alexmingoia]

I've made both your suggested changes. Thanks for taking a look at this.

[connec]

Thank you both for the PR, apologies for taking so long to get to it. I'll just wait for the workflows to pass then go ahead with a merge.