Skip to content

fix: update sqlx to 0.6#11

Merged
connec merged 1 commit intodigital-society-coop:masterfrom
greizgh:fix/update-sqlx
Sep 20, 2022
Merged

fix: update sqlx to 0.6#11
connec merged 1 commit intodigital-society-coop:masterfrom
greizgh:fix/update-sqlx

Conversation

@greizgh
Copy link
Contributor

@greizgh greizgh commented Aug 9, 2022

This will closes #10

@sedrik
Copy link

sedrik commented Aug 15, 2022

Would it make sense to upgrade to 0.6.1 now that it is out? :)

@greizgh
Copy link
Contributor Author

greizgh commented Aug 15, 2022

Would it make sense to upgrade to 0.6.1 now that it is out? :)

The constraint has been changed to "0.6", so it will accept "0.6.1" and any other "0.6.x" version.
Since this crate is used as a lib, my understanding is that it should accept the lowest possible version ("0.6.0") and not have strict constraint to match applications' one. That is, if at some point in my app I have sqlx 0.6.5, I want the lib to use 0.6.5 (that is, unless there is a missing feature or breaking change, which doesn't seem to be the case here).

@sedrik
Copy link

sedrik commented Aug 15, 2022

Ah yes, my bad :)

@connec
Copy link
Member

connec commented Sep 20, 2022

Oh thanks for this! I'll take a look at it very soon. Notifications for this project are turned off for some reason 😅

@connec
Copy link
Member

connec commented Sep 20, 2022

Thank you. I'll follow this up with a release imminently.

@connec connec merged commit e08e708 into digital-society-coop:master Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

trait bound Postgres: sqlx_core::database::Database is not satisfied

3 participants