Skip to content

Improvement/linting setup #2042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 15 commits into
base: develop
Choose a base branch
from

Conversation

Saurabh2402
Copy link

@Saurabh2402 Saurabh2402 commented Jul 23, 2025

🔧 Add Linting Configuration and Apply Staticcheck Fixes

Step2 towards #2029

Changes Made

📋 Linting Configuration

  • Extended .golangci.yml with linting section
  • Added linters configuration with default: none
  • Enabled staticcheck linter for comprehensive static analysis

🔍 Static Analysis Fixes

  • Executed staticcheck linter across the entire repository
  • Applied auto-fixable suggestions to improve code quality

🔄 Branch Synchronization

@Saurabh2402
Copy link
Author

Saurabh2402 commented Jul 23, 2025

⚠️ Code Style Questions for Maintainer @motatoes

Error String Conventions:

  1. Should we follow Go's convention of not capitalising error strings?
  2. Should we avoid ending error strings with punctuation per Go conventions?
  3. Here is one of the example, the codebase has similar implementation of error vars at other places: CodeLink

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant