SMV: complex identifiers are now parsed as expressions #1195
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NuSMV allows a subset of the expression syntax to be used as variable identifiers. This changes the SMV grammar to use expressions to store the result of the complex_identifier rule.
tautschnig
approved these changes
Jul 11, 2025
| else if(expr.id() == ID_member) | ||
| { | ||
| auto &member_expr = to_member_expr(expr); | ||
| return id2string(merge_complex_identifier(member_expr.compound())) + '.' + id2string(member_expr.get_component_name()); |
There was a problem hiding this comment.
In CBMC's field sensitivity encoding we chose .. as separator to avoid confusing humans as to whether they see an identifier or an expression. Would that also be a possible concern (and solution) here?
There was a problem hiding this comment.
I did worry about this, but SMV doesn't have a struct type.
| auto &index = index_expr.index(); | ||
| PRECONDITION(index.is_constant()); | ||
| auto index_string = id2string(to_constant_expr(index).get_value()); | ||
| return id2string(merge_complex_identifier(index_expr.array())) + '.' + index_string; |
There was a problem hiding this comment.
In keeping with the above comment: would "[[" + index_string + "]]" be a more human-friendly choice?
There was a problem hiding this comment.
SMV does have an array type, and confusingly, uses the same syntax for those identifiers and arrays. Using say [[ would make the difference clear, but then be incompatible with NuSMV.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NuSMV allows a subset of the expression syntax to be used as variable identifiers. This changes the SMV grammar to use expressions to store the result of the
complex_identifierrule.