Skip to content

Add invariant that multiplication uses operands of the same size #8241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 20, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/solvers/flattening/bv_utils.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1071,6 +1071,11 @@ bvt bv_utilst::multiplier(
const bvt &op1,
representationt rep)
{
// We determine the result size from the operand size, and the implementation
// liberally swaps the operands, so we need to arrive at the same size
// whatever the order of the operands.
PRECONDITION(op0.size() == op1.size());

switch(rep)
{
case representationt::SIGNED: return signed_multiplier(op0, op1);
Expand Down