Skip to content

Hide __CPROVER_deallocated updates behind a function #6859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 17, 2022

Conversation

tautschnig
Copy link
Collaborator

This avoids repeating similar code in several places.

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@tautschnig tautschnig self-assigned this May 16, 2022
@tautschnig tautschnig force-pushed the feature/cprover_deallocate branch from 69d0046 to 3427c6c Compare May 16, 2022 20:12
This avoids repeating similar code in several places.
@tautschnig tautschnig force-pushed the feature/cprover_deallocate branch from 3427c6c to 5d74a03 Compare May 16, 2022 21:10
@codecov
Copy link

codecov bot commented May 16, 2022

Codecov Report

Merging #6859 (5d74a03) into develop (a9ddceb) will increase coverage by 0.00%.
The diff coverage is 60.31%.

@@           Coverage Diff            @@
##           develop    #6859   +/-   ##
========================================
  Coverage    77.78%   77.78%           
========================================
  Files         1567     1567           
  Lines       179701   179701           
========================================
+ Hits        139788   139789    +1     
+ Misses       39913    39912    -1     
Impacted Files Coverage Δ
src/analyses/cfg_dominators.h 100.00% <ø> (ø)
src/analyses/invariant_set_domain.cpp 0.00% <0.00%> (ø)
src/ansi-c/ansi_c_internal_additions.cpp 90.12% <ø> (ø)
src/goto-instrument/dot.cpp 0.00% <0.00%> (ø)
src/goto-programs/remove_returns.cpp 98.15% <ø> (ø)
src/goto-programs/show_goto_functions_xml.cpp 0.00% <0.00%> (ø)
src/goto-symex/symex_goto.cpp 97.12% <ø> (ø)
src/goto-symex/symex_main.cpp 86.97% <0.00%> (ø)
src/goto-symex/solver_hardness.cpp 53.00% <11.11%> (ø)
src/goto-instrument/wmm/goto2graph.cpp 54.49% <12.50%> (ø)
... and 29 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 970cc26...5d74a03. Read the comment docs.

@tautschnig tautschnig merged commit 1cfc93f into diffblue:develop May 17, 2022
@tautschnig tautschnig deleted the feature/cprover_deallocate branch May 17, 2022 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants