Skip to content

introduce rounding_mode_identifier() #6289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 16, 2021
Merged

Conversation

kroening
Copy link
Member

This commit consolidates the various places that contain the string
CPROVER_PREFIX "rounding_mode".

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

Copy link
Collaborator

@tautschnig tautschnig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps the commit message should be a bit more accurate in that this commit does not capture the uses in the C library.

@kroening kroening force-pushed the rounding_mode_identifier branch 3 times, most recently from 9b29114 to a5804d5 Compare August 14, 2021 11:00
This commit consolidates the various places in the CBMC source that contain
the string CPROVER_PREFIX "rounding_mode".  The usage in the C library are
not included.
@kroening kroening force-pushed the rounding_mode_identifier branch from a5804d5 to a0a1329 Compare August 16, 2021 16:54
@codecov
Copy link

codecov bot commented Aug 16, 2021

Codecov Report

Merging #6289 (a0a1329) into develop (63203b1) will increase coverage by 0.00%.
The diff coverage is 70.83%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #6289   +/-   ##
========================================
  Coverage    75.98%   75.98%           
========================================
  Files         1510     1510           
  Lines       163465   163467    +2     
========================================
+ Hits        124208   124213    +5     
+ Misses       39257    39254    -3     
Impacted Files Coverage Δ
src/jsil/jsil_entry_point.cpp 0.00% <0.00%> (ø)
src/jsil/jsil_internal_additions.cpp 0.00% <0.00%> (ø)
src/util/floatbv_expr.cpp 0.00% <0.00%> (ø)
src/util/floatbv_expr.h 73.58% <ø> (ø)
src/util/ieee_float.cpp 88.01% <0.00%> (ø)
src/util/ieee_float.h 85.71% <ø> (ø)
...java_bytecode/java_bytecode_internal_additions.cpp 100.00% <100.00%> (ø)
jbmc/src/java_bytecode/java_entry_point.cpp 89.06% <100.00%> (ø)
src/analyses/constant_propagator.cpp 95.06% <100.00%> (ø)
...yses/variable-sensitivity/abstract_environment.cpp 95.02% <100.00%> (ø)
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be17ef4...a0a1329. Read the comment docs.

@kroening kroening marked this pull request as ready for review August 16, 2021 19:02
@kroening kroening merged commit 6fbb492 into develop Aug 16, 2021
@kroening kroening deleted the rounding_mode_identifier branch August 16, 2021 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants