Remove conversion_failed(exprt, bvt)

[tautschnig]

This just invited the anti-pattern of uselessly building a bvt of a
certain size when it got completely replaced by the function call
anyway.

• Each commit message has a non-empty body, explaining why the change was made.
• n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
• n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
• Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
• n/a My commit message includes data points confirming performance improvements (if claimed).
• My PR is restricted to a single feature or bugfix.
• n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

[codecov]

Codecov Report

Merging #6139 (3b954ab) into develop (763f6a2) will increase coverage by 0.36%.
The diff coverage is 95.38%.

@@             Coverage Diff             @@
##           develop    #6139      +/-   ##
===========================================
+ Coverage    74.90%   75.26%   +0.36%     
===========================================
  Files         1447     1447              
  Lines       158198   158205       +7     
===========================================
+ Hits        118491   119066     +575     
+ Misses       39707    39139     -568     

Impacted Files	Coverage Δ
src/goto-instrument/code_contracts.h	93.75% <ø> (ø)
src/solvers/flattening/boolbv.h	76.19% <ø> (+6.62%)	⬆️
src/solvers/flattening/bv_pointers.cpp	82.43% <0.00%> (+1.17%)	⬆️
src/goto-instrument/code_contracts.cpp	85.45% <100.00%> (+0.10%)	⬆️
src/util/c_types.h	100.00% <100.00%> (+1.80%)	⬆️
src/ansi-c/gcc_types.cpp	41.86% <0.00%> (-46.52%)	⬇️
src/ansi-c/literals/convert_float_literal.cpp	73.80% <0.00%> (-19.05%)	⬇️
src/ansi-c/c_typecheck_code.cpp	66.26% <0.00%> (-11.66%)	⬇️
src/ansi-c/c_storage_spec.cpp	86.84% <0.00%> (-10.53%)	⬇️
src/util/std_types.cpp	83.95% <0.00%> (-4.94%)	⬇️
... and 31 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 66d9d17...3b954ab. Read the comment docs.