Configure bits_per_byte in byte_extract/byte_update expression #6009
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tautschnig
force-pushed
the
byte-operator-bits-per-byte
branch
4 times, most recently
from
5f7915f to
d4081c2
Compare
Codecov ReportBase: 77.99% // Head: 78.00% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #6009 +/- ##
========================================
Coverage 77.99% 78.00%
========================================
Files 1619 1619
Lines 187184 187248 +64
========================================
+ Hits 145999 146062 +63
- Misses 41185 41186 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
tautschnig
force-pushed
the
byte-operator-bits-per-byte
branch
from
d4081c2 to
b68ddd2
Compare
tautschnig
force-pushed
the
byte-operator-bits-per-byte
branch
from
b68ddd2 to
9c017d7
Compare
tautschnig
requested review from
chrisr-diffblue,
kroening,
martin-cs,
peterschrammel,
romainbrenguier and
smowton
as code owners
martin-cs
approved these changes
Apr 6, 2021
jbmc/unit/java_bytecode/java_trace_validation/java_trace_validation.cpp
Outdated
Show resolved
Hide resolved
tautschnig
force-pushed
the
byte-operator-bits-per-byte
branch
from
9c017d7 to
2a26e7a
Compare
While I do know of an organisation that had a use case, I'm not sure they are still using CBMC. Either way, I'd like to get rid of all magic numbers. |
tautschnig
force-pushed
the
byte-operator-bits-per-byte
branch
from
2a26e7a to
7b059a6
Compare
tautschnig
force-pushed
the
byte-operator-bits-per-byte
branch
from
7b059a6 to
5a19700
Compare
tautschnig
force-pushed
the
byte-operator-bits-per-byte
branch
from
5a19700 to
33eb105
Compare
tautschnig
force-pushed
the
byte-operator-bits-per-byte
branch
from
33eb105 to
4b6c927
Compare
tautschnig
force-pushed
the
byte-operator-bits-per-byte
branch
from
4b6c927 to
1b3a39d
Compare
Semantically evaluating a byte_extract/byte_update expression requires knowledge of the number of bits that a byte is composed of. This, however, is a configuration parameter known to the front-end that created the expression in the first place. The back-end should not need to consult configuration information to evaluate the expression.
tautschnig
force-pushed
the
byte-operator-bits-per-byte
branch
from
1b3a39d to
a8631c5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Semantically evaluating a byte_extract/byte_update expression requires
knowledge of the number of bits that a byte is composed of. This,
however, is a configuration parameter known to the front-end that
created the expression in the first place. The back-end should not need
to consult configuration information to evaluate the expression.