Provide implementations of __builtin_ia32_vec_ext_* #5919
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tautschnig
force-pushed
the
fix-5903
branch
2 times, most recently
from
df0a797 to
dd80b7f
Compare
Codecov Report
@@ Coverage Diff @@
## develop #5919 +/- ##
===========================================
+ Coverage 75.02% 75.04% +0.01%
===========================================
Files 1431 1433 +2
Lines 155595 155800 +205
===========================================
+ Hits 116734 116918 +184
- Misses 38861 38882 +21
Continue to review full report at Codecov.
|
tautschnig
force-pushed
the
fix-5903
branch
5 times, most recently
from
f91a28b to
4f1ac87
Compare
tautschnig
changed the title
tautschnig
force-pushed
the
fix-5903
branch
2 times, most recently
from
36d4e2d to
a7d0ef9
Compare
tautschnig
requested review from
chrisr-diffblue,
kroening,
peterschrammel and
smowton
as code owners
tautschnig
changed the title
kroening
reviewed
Mar 26, 2021
regression/cbmc/SIMD1/test.desc
Outdated
| @@ -0,0 +1,8 @@ | |||
| CORE gcc-only broken-smt-backend | |||
There was a problem hiding this comment.
Still broken after #5974? Also, there is an #ifdef _MSC_VER in the test, which suggests it might work on Visual Studio?
There was a problem hiding this comment.
The SMT conversion still fails (at src/solvers/smt2/smt2_conv.cpp:2531 function: convert_typecast), but Visual Studio should indeed be ok. Fixed.
kroening
approved these changes
Mar 26, 2021
tautschnig
force-pushed
the
fix-5903
branch
3 times, most recently
from
4bc80ac to
a36b170
Compare
Additional declarations based on Clang's BuiltinsX86.def. For `__builtin_ia32_sqrtpd512` and `__builtin_ia32_sqrtps512`, Clang and GCC disagree about the number of parameters (GCC supports one, Clang supports two).
We previously only transformed the left-hand side and arguments, but skipped over the function itself. This omission became apparent when trying to run the upcoming SIMD1 test (added in a later commit, further bug fixes are necessary).
This omission became apparent when trying to run the upcoming SIMD1 test (added in a later commit, further bug fixes are necessary).
These built-ins extract an element of a vector. Fixes: diffblue#5903
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These built-ins extract an element of a vector.
Fixes: #5903
Includes #5913, and will remain a Draft until that PR is merged.