Move C types into util/c_types.h #5899
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
kroening
commented
Mar 8, 2021
kroening
commented
- Each commit message has a non-empty body, explaining why the change was made.
- n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
- n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
- n/a Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
- n/a My commit message includes data points confirming performance improvements (if claimed).
- My PR is restricted to a single feature or bugfix.
- n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.
tautschnig
approved these changes
Mar 8, 2021
Codecov Report
@@ Coverage Diff @@
## develop #5899 +/- ##
===========================================
+ Coverage 73.37% 73.55% +0.18%
===========================================
Files 1428 1430 +2
Lines 155121 155222 +101
===========================================
+ Hits 113813 114170 +357
+ Misses 41308 41052 -256
Continue to review full report at Codecov.
|
kroening
force-pushed
the
move_c_types
branch
2 times, most recently
from
caea3ff to
4cd800e
Compare
kroening
requested review from
allredj,
chrisr-diffblue,
hannes-steffenhagen-diffblue,
martin-cs,
peterschrammel,
romainbrenguier and
smowton
as code owners
peterschrammel
approved these changes
Mar 10, 2021
The rationale is that types of a particular group (say bitvectors or pointers) are often used together with the expressions that are specific for them. The goal is that std_types.h will only contain the basic types, such as bool_typet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.