VSD - Further cross-representation expression evaluation #5887
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As we look to do cross-representation evaluation, it's no longer meanful to have separate tests for "expressions involving constants", etc
rewrite_expression has, incorrectly, expected every term in the rewritten expression to be a constant. When there are intervals in play, this is clearly not the case. When we encounter an interval, don't attempt to coerce it to a constant expression, simply use the existing operand.
A constant of, say, 5 has a index_range of 5. A value_set of { 5, 6,
9 } therefore has an index_range of 5,6,9.
An interval of [1, 3] has an index_range of 1,2,3. A value_set
containing that interval should have the same index_range.
A value_set of multiple constants and intervals should have an
index_range which is the union of its contents index_range.
jezhiggins
requested review from
chrisr-diffblue,
martin-cs,
peterschrammel and
smowton
as code owners
Codecov Report
@@ Coverage Diff @@
## develop #5887 +/- ##
===========================================
+ Coverage 72.95% 73.09% +0.13%
===========================================
Files 1425 1428 +3
Lines 154281 155058 +777
===========================================
+ Hits 112561 113341 +780
+ Misses 41720 41717 -3
Continue to review full report at Codecov.
|
martin-cs
approved these changes
Mar 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR follows on from #5880, completing the implementation work for value-sets and intervals.
The bulk of the PR is additional unit tests, confirming behaviour for the various combinations of constants, intervals, value-sets of constants, value-sets of intervals, and value-sets with mixed content.
The functional changes are quite small - a fix to value-set evaluation to properly handle intervals and a similar change to value-set index ranges (used when indexing into arrays) to remove the assumption the contents are all constants.