Skip to content

remove_const_function_pointerst isn't a messaget #5614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

tautschnig
Copy link
Collaborator

Use a messaget member instead as there is no is-a relationship between
remove_const_function_pointerst and messaget.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@codecov
Copy link

codecov bot commented Nov 18, 2020

Codecov Report

Merging #5614 (82cfbd4) into develop (4144414) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #5614   +/-   ##
========================================
  Coverage    69.32%   69.32%           
========================================
  Files         1241     1241           
  Lines       100432   100432           
========================================
  Hits         69625    69625           
  Misses       30807    30807           
Flag Coverage Δ
cproversmt2 43.08% <66.66%> (ø)
regression 66.22% <100.00%> (ø)
unit 32.27% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...c/goto-programs/remove_const_function_pointers.cpp 81.21% <100.00%> (ø)
src/goto-programs/remove_const_function_pointers.h 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4144414...82cfbd4. Read the comment docs.

Use a messaget member instead as there is no is-a relationship between
remove_const_function_pointerst and messaget.
@tautschnig tautschnig force-pushed the messaget-remove_const_function_pointers branch from 4bea8ee to 82cfbd4 Compare November 19, 2020 10:14
@tautschnig tautschnig merged commit f2d735a into diffblue:develop Nov 19, 2020
@tautschnig tautschnig deleted the messaget-remove_const_function_pointers branch November 19, 2020 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants