Skip to content

run() Windows error reporting #5601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 17, 2020

Conversation

tautschnig
Copy link
Collaborator

Adds reporting of system errors and a unit test thereof.

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@codecov
Copy link

codecov bot commented Nov 16, 2020

Codecov Report

Merging #5601 (80647dd) into develop (dcf92fe) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #5601   +/-   ##
========================================
  Coverage    69.33%   69.33%           
========================================
  Files         1242     1242           
  Lines       100412   100412           
========================================
  Hits         69616    69616           
  Misses       30796    30796           
Flag Coverage Δ
cproversmt2 43.10% <ø> (ø)
regression 66.22% <ø> (ø)
unit 32.29% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/util/run.cpp 76.34% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dcf92fe...80647dd. Read the comment docs.

@tautschnig tautschnig force-pushed the run-windows-error-reporting branch from 27243cb to 1b533af Compare November 16, 2020 11:04
On non-Windows platforms we output information using perror. Do the
equivalent for Windows, following https://stackoverflow.com/a/17387176.
@tautschnig tautschnig force-pushed the run-windows-error-reporting branch from 1b533af to 90c3f7e Compare November 16, 2020 13:32
We do implicitly use run() in various tests, but are unlikely to
exercise error paths in those tests. Take care of doing so in a unit
test.
@tautschnig tautschnig force-pushed the run-windows-error-reporting branch from 90c3f7e to 80647dd Compare November 16, 2020 15:25
@kroening kroening merged commit 1302159 into diffblue:develop Nov 17, 2020
@tautschnig tautschnig deleted the run-windows-error-reporting branch November 17, 2020 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants