Skip to content

Coverage goal filters aren't messaget #5589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 17, 2020

Conversation

tautschnig
Copy link
Collaborator

@tautschnig tautschnig commented Nov 14, 2020

The classes didn't use messaget anyway.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@codecov
Copy link

codecov bot commented Nov 14, 2020

Codecov Report

Merging #5589 (e6abdd0) into develop (c1c0356) will increase coverage by 0.00%.
The diff coverage is 66.66%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #5589   +/-   ##
========================================
  Coverage    69.32%   69.33%           
========================================
  Files         1242     1242           
  Lines       100418   100409    -9     
========================================
- Hits         69619    69614    -5     
+ Misses       30799    30795    -4     
Flag Coverage Δ
cproversmt2 43.09% <22.22%> (-0.01%) ⬇️
regression 66.22% <22.22%> (+<0.01%) ⬆️
unit 32.26% <66.66%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/goto-instrument/cover.cpp 84.78% <66.66%> (+0.49%) ⬆️
src/goto-instrument/cover_filter.h 86.95% <66.66%> (+6.95%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c1c0356...e6abdd0. Read the comment docs.

The classes didn't use `messaget` anyway.
@tautschnig tautschnig merged commit 6feef01 into diffblue:develop Nov 17, 2020
@tautschnig tautschnig deleted the messaget-cover branch November 17, 2020 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants