Skip to content

Symex: clean up quantifier rewriting #4310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 4, 2019

Conversation

smowton
Copy link
Contributor

@smowton smowton commented Mar 1, 2019

  1. Don't use the sharing-breaking rewrite_quantifiers routine unless there is a forall-quantifier
    in the expression.
  2. Comment to explain why we look for existential quantifiers, even though the rewrite routine
    doesn't actually directly handle them.

@smowton smowton force-pushed the smowton/fix/symex-exist-quant branch from 2904dcf to 495ac02 Compare March 1, 2019 17:49
@tautschnig
Copy link
Collaborator

Hmm, there is #3925, which invalidates some of what is being done here. I don't mind rebasing #3925 on top of this one, but it would amount to a revert of sorts.

Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️
Passed Diffblue compatibility checks (cbmc commit: 495ac02).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/102857597

@smowton smowton force-pushed the smowton/fix/symex-exist-quant branch 2 times, most recently from 88424ea to 9e33931 Compare March 4, 2019 09:48
@smowton
Copy link
Contributor Author

smowton commented Mar 4, 2019

@tautschnig reverted the move and rename accordingly; kept sparing sharing when the simplify does not introduce a forall-expr, which will still apply even after #3925.

Copy link
Collaborator

@tautschnig tautschnig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, I quite liked the text move actually, although it will cause some conflicts that I'll need to resolve. And this still needs a rebase.

@smowton smowton force-pushed the smowton/fix/symex-exist-quant branch from 9e33931 to 242a643 Compare March 4, 2019 12:01
@smowton smowton closed this Mar 4, 2019
@smowton smowton force-pushed the smowton/fix/symex-exist-quant branch from 242a643 to ec1e98e Compare March 4, 2019 12:16
@smowton smowton reopened this Mar 4, 2019
smowton added 2 commits March 4, 2019 12:29
1. Don't use the sharing-breaking rewrite_quantifiers routine unless there is a forall-quantifier
   in the expression.
2. Comment to explain why we look for existential quantifiers, even though the rewrite routine
   doesn't actually directly handle them.
@smowton smowton force-pushed the smowton/fix/symex-exist-quant branch from ec1e98e to 9891174 Compare March 4, 2019 12:29
@tautschnig tautschnig merged commit b54448c into diffblue:develop Mar 4, 2019
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️
This PR failed Diffblue compatibility checks (cbmc commit: 9891174).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/103044562
Status will be re-evaluated on next push.
Common spurious failures:

  • the cbmc commit has disappeared in the mean time (e.g. in a force-push)

  • the author is not in the list of contributors (e.g. first-time contributors).

  • the compatibility was already broken by an earlier merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants