-
Notifications
You must be signed in to change notification settings - Fork 277
Symex: clean up quantifier rewriting #4310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Symex: clean up quantifier rewriting #4310
Conversation
2904dcf
to
495ac02
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✔️
Passed Diffblue compatibility checks (cbmc commit: 495ac02).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/102857597
88424ea
to
9e33931
Compare
@tautschnig reverted the move and rename accordingly; kept sparing sharing when the simplify does not introduce a forall-expr, which will still apply even after #3925. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, I quite liked the text move actually, although it will cause some conflicts that I'll need to resolve. And this still needs a rebase.
9e33931
to
242a643
Compare
242a643
to
ec1e98e
Compare
1. Don't use the sharing-breaking rewrite_quantifiers routine unless there is a forall-quantifier in the expression. 2. Comment to explain why we look for existential quantifiers, even though the rewrite routine doesn't actually directly handle them.
ec1e98e
to
9891174
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR failed Diffblue compatibility checks (cbmc commit: 9891174).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/103044562
Status will be re-evaluated on next push.
Common spurious failures:
-
the cbmc commit has disappeared in the mean time (e.g. in a force-push)
-
the author is not in the list of contributors (e.g. first-time contributors).
-
the compatibility was already broken by an earlier merge.
in the expression.
doesn't actually directly handle them.