Skip to content

Allow lint to be called from any folder #427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 12, 2017
Merged

Allow lint to be called from any folder #427

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions scripts/run_lint.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@

set -e

script_folder=`dirname $0`

if [[ "$#" -ne 2 ]]
then
echo "Script for running the CPP linter only on modified lines."
Expand All @@ -12,10 +14,10 @@ then
exit 1
fi

if ! [[ -e scripts/cpplint.py ]]
if ! [[ -e $script_folder/cpplint.py ]]
then
echo "Lint script could not be found in the scripts directory"
echo "Ensure cpplint.py is inside the scripts directory then run again"
echo "Lint script could not be found in the $script_folder directory"
echo "Ensure cpplint.py is inside the $script_folder directory then run again"
exit 1
fi

Expand Down Expand Up @@ -81,7 +83,7 @@ for file in $diff_files; do
# Run the linting script and filter by the filter we've build
# of all the modified lines
# The errors from the linter go to STDERR so must be redirected to STDOUT
result=`python scripts/cpplint.py $file 2>&1 | { grep -E "$lint_grep_filter" || true; }`
result=`python $script_folder/cpplint.py $file 2>&1 | { grep -E "$lint_grep_filter" || true; }`

# Providing some errors were relevant we print them out
if [ "$result" ]
Expand Down