Skip to content

taint_analysist isn't a messaget [blocks: #3800] #4051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 7, 2019

Conversation

tautschnig
Copy link
Collaborator

Pass a message handler to the methods that use it. Also make use of
conditional_output to avoid generating a debug string (instead of just not
printing it).

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️
Passed Diffblue compatibility checks (cbmc commit: 79ccaa3).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/99552621

@kroening
Copy link
Member

kroening commented Feb 8, 2019

Argument lists are getting long -- simply make that log a member?

@tautschnig
Copy link
Collaborator Author

Argument lists are getting long -- simply make that log a member?

Done!

Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️
Passed Diffblue compatibility checks (cbmc commit: 17d7dbb).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/100292616

@tautschnig tautschnig force-pushed the messaget-taint_analysis branch from 17d7dbb to 38f23b0 Compare February 27, 2019 01:26
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️
Passed Diffblue compatibility checks (cbmc commit: 38f23b0).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/102433787

Use a messaget member instead. Also make use of conditional_output to avoid
generating a debug string (instead of just not printing it).
@tautschnig tautschnig force-pushed the messaget-taint_analysis branch from 38f23b0 to f8b49a0 Compare March 6, 2019 23:36
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️
Passed Diffblue compatibility checks (cbmc commit: f8b49a0).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/103463260

@tautschnig tautschnig merged commit 24295fa into diffblue:develop Mar 7, 2019
@tautschnig tautschnig deleted the messaget-taint_analysis branch March 7, 2019 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants