-
Notifications
You must be signed in to change notification settings - Fork 277
Avoid default constructing code_ifthenelset [blocks: #3800] #3935
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid default constructing code_ifthenelset [blocks: #3800] #3935
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫
This PR failed Diffblue compatibility checks (cbmc commit: 2cda7c2).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/98600308
Status will be re-evaluated on next push.
Please contact @peterschrammel, @thk123, or @allredj for support.
Common spurious failures:
- the cbmc commit has disappeared in the mean time (e.g. in a force-push)
- the author is not in the list of contributors (e.g. first-time contributors).
The incompatibility may have been introduced by an earlier PR. In that case merging this
PR should be avoided unless it fixes the current incompatibility.
2cda7c2
to
c5c4c7b
Compare
if(throw_runtime_exceptions) | ||
{ | ||
check_code= | ||
return code_ifthenelset( | ||
notequal_exprt( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keep this test code factored
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you mind taking another look? I believe I have addressed your concern.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✔️
Passed Diffblue compatibility checks (cbmc commit: c5c4c7b).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/98708510
The default constructor is deprecated.
c5c4c7b
to
339641c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✔️
Passed Diffblue compatibility checks (cbmc commit: 339641c).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/98716526
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideal! Of course it's not really optional, but this is a good pattern for checking it really did get assigned as it ought to have been :)
The default constructor is deprecated.