Skip to content

Cleanup value_set_dereferencet's internal API [blocks: #2310] #3344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 11, 2018

Conversation

tautschnig
Copy link
Collaborator

@tautschnig tautschnig commented Nov 10, 2018

Several parameters were no longer used and thus unnecessarily being passed
around.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • White-space or formatting changes outside the feature-related changed lines are in commits of their own.

Several parameters were no longer used and thus unnecessarily being passed
around.
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️
Passed Diffblue compatibility checks (cbmc commit: 71d6013).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/90952270

@tautschnig tautschnig merged commit d1a4c13 into diffblue:develop Nov 11, 2018
@tautschnig tautschnig deleted the vs-cleanup-deref branch November 11, 2018 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants