Skip to content

add 'override' in cpp_typecheckt #3163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 14, 2018
Merged

add 'override' in cpp_typecheckt #3163

merged 2 commits into from
Oct 14, 2018

Conversation

kroening
Copy link
Member

also removes some parameter declarators that do not add information

  • Each commit message has a non-empty body, explaining why the change was made.
  • My contribution is formatted in line with CODING_STANDARD.md.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • White-space or formatting changes outside the feature-related changed lines are in commits of their own.

Copy link
Collaborator

@tautschnig tautschnig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a good idea and thus my approval of this in principle - but it doesn't actually compile.

@kroening
Copy link
Member Author

The CI fails because of Doxygen; I will see if that can be fixed.

Daniel Kroening added 2 commits October 14, 2018 19:15
@kroening kroening force-pushed the cpp_typecheckt_override branch from a186b2a to 1be285f Compare October 14, 2018 18:15
@kroening kroening merged commit fbd2afe into develop Oct 14, 2018
@kroening kroening deleted the cpp_typecheckt_override branch October 14, 2018 19:40
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passed Diffblue compatibility checks (cbmc commit: 1be285f).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/87888797

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants