Skip to content

Cleanup error handling elf reader #2955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 3, 2018
Merged

Cleanup error handling elf reader #2955

merged 1 commit into from
Oct 3, 2018

Conversation

chrisr-diffblue
Copy link
Contributor

@chrisr-diffblue chrisr-diffblue commented Sep 14, 2018 •
edited
Loading

No description provided.

allredj
allredj reviewed Sep 14, 2018
View reviewed changes
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passed Diffblue compatibility checks (cbmc commit: bd5d2f6).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/84832352

kroening
kroening requested changes Sep 18, 2018
View reviewed changes
Copy link
Member

@kroening kroening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am concerned that there will be a long list of different exceptions that are to be caught in the driver programs (and sometimes forgotten to be caught).

Furthermore, there are a lot of similar exception classes, basically containing a string with an error message.

These could be summarised in some base exception class, and then caught by catching the base class.

@tautschnig
Copy link
Collaborator

These could be summarised in some base exception class, and then caught by catching the base class.

Can this be resolved by making deserialization_exceptiont inherit from some invalid_input_exceptiont?

@chrisr-diffblue chrisr-diffblue force-pushed the cleanup-error-handling-elf_reader branch from bd5d2f6 to f17ae97 Compare September 20, 2018 12:08
@chrisr-diffblue
Copy link
Contributor Author

@kroening - This PR has now been rebased which picks up #2996 (which has been merged into develop). I think that PR addresses your concern around the proliferation of exception classes and handlers for them. Would you mind taking another look at this PR?

allredj
allredj reviewed Sep 20, 2018
View reviewed changes
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passed Diffblue compatibility checks (cbmc commit: f17ae97).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/85433227

@chrisr-diffblue
Copy link
Contributor Author

@kroening Would you be able to re-review this PR to see if your blocking comment is still applicable or not? I think it's been addressed now.

@kroening kroening merged commit 1f59dd8 into diffblue:develop Oct 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allredj allredj allredj left review comments

@kroening kroening kroening approved these changes

@peterschrammel peterschrammel peterschrammel approved these changes

@pkesseli pkesseli Awaiting requested review from pkesseli

@smowton smowton Awaiting requested review from smowton

@tautschnig tautschnig Awaiting requested review from tautschnig tautschnig is a code owner

Assignees

@kroening kroening

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@chrisr-diffblue @tautschnig @kroening @peterschrammel @allredj