Error handling cleanup in solvers/floatbv #2945
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allredj
reviewed
Sep 13, 2018
There was a problem hiding this comment.
Passed Diffblue compatibility checks (cbmc commit: 9df60c6).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/84700185
tautschnig
reviewed
Sep 19, 2018
src/solvers/floatbv/float_bv.cpp
Outdated
| @@ -810,9 +812,9 @@ exprt float_bvt::relation( | |||
| not_exprt(nan)); | |||
| } | |||
| else | |||
| assert(0); | |||
| UNREACHABLE; | |||
There was a problem hiding this comment.
Maybe this else branch should just be removed? It's redundant with the code afterwards.
src/solvers/floatbv/float_utils.cpp
Outdated
| @@ -646,15 +644,16 @@ literalt float_utilst::relation( | |||
| !NaN); | |||
| } | |||
| else | |||
| assert(0); | |||
| UNREACHABLE; | |||
There was a problem hiding this comment.
Redundant with the code afterwards, just remove the else branch
danpoe
force-pushed
the
refactor/error-handling-solvers-floatbv
branch
from
9df60c6 to
98538b4
Compare
allredj
reviewed
Sep 24, 2018
There was a problem hiding this comment.
Passed Diffblue compatibility checks (cbmc commit: 98538b4).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/85736377
kroening
reviewed
Oct 3, 2018
kroening
approved these changes
Oct 3, 2018
danpoe
force-pushed
the
refactor/error-handling-solvers-floatbv
branch
from
98538b4 to
0dce179
Compare
allredj
reviewed
Oct 4, 2018
There was a problem hiding this comment.
Passed Diffblue compatibility checks (cbmc commit: 0dce179).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/86879780
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.