Revert "Disable OSX builds" #1391
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I suggest we restart the build every evening to see if it has got better (the last build took 5 hours so definitely not yet fixed...) |
|
Ran this last night, took 2 hrs 28 min so I think that is still slow (albeit faster...) I will try again tonight. |
peterschrammel
force-pushed
the
revert-1387-feature/disable-mac-builds
branch
from
7fd9f8e to
abeba21
Compare
|
Builds look reasonable again, but perhaps unsurprisingly looks like something broke while these were turned off. It appears to be to do with the new symbol table unit tests. Suggest poking @smowton |
This was revealed by re-enabling the OSX build, which evidently is quicker to re-use the memory formerly occupied by the pair<key, value>!
|
Could you rebase on #1520 to find out if that fixes it as expected? |
|
Never mind cherry-picked this into #1520 |
peterschrammel
force-pushed
the
revert-1387-feature/disable-mac-builds
branch
from
abeba21 to
798eceb
Compare
|
Applied along with the corresponding fix in #1520 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be merged as soon as travis macos builds perform reasonably again.
Reverts #1387