Skip to content

fix verbosity in goto-gcc #1294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 5, 2017
Merged

fix verbosity in goto-gcc #1294

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions regression/goto-gcc/verbosity1/main.c
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
int main()
{
return 0;
}
9 changes: 9 additions & 0 deletions regression/goto-gcc/verbosity1/test.desc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
CORE
main.c
--version
^EXIT=0$
^SIGNAL=0$
--
^RUN: .* --version
^warning: ignoring
^CONVERSION ERROR$
4 changes: 4 additions & 0 deletions regression/goto-gcc/verbosity2/main.c
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
int main()
{
return 0;
}
9 changes: 9 additions & 0 deletions regression/goto-gcc/verbosity2/test.desc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
CORE
main.c
--version --verbosity 10
^EXIT=0$
^SIGNAL=0$
^RUN: .* --version
--
^warning: ignoring
^CONVERSION ERROR$
16 changes: 8 additions & 8 deletions src/goto-cc/gcc_mode.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -333,6 +333,14 @@ int gcc_modet::doit()

unsigned int verbosity=1;

if(cmdline.isset("Wall") || cmdline.isset("Wextra"))
verbosity=2;

if(cmdline.isset("verbosity"))
verbosity=unsafe_string2unsigned(cmdline.get_value("verbosity"));

gcc_message_handler.set_verbosity(verbosity);

bool act_as_bcc=
base_name=="bcc" ||
base_name.find("goto-bcc")!=std::string::npos;
Expand Down Expand Up @@ -381,14 +389,6 @@ int gcc_modet::doit()
return EX_OK;
}

if(cmdline.isset("Wall") || cmdline.isset("Wextra"))
verbosity=2;

if(cmdline.isset("verbosity"))
verbosity=unsafe_string2unsigned(cmdline.get_value("verbosity"));

gcc_message_handler.set_verbosity(verbosity);

if(act_as_ld)
{
if(produce_hybrid_binary)
Expand Down