-
Notifications
You must be signed in to change notification settings - Fork 277
Allow anonymous namespaces #1031
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow anonymous namespaces #1031
Conversation
Rebased @peterschrammel. Linter fails because of the regression tests for the linter. |
How does this interact with namespace aliases i.e. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please document the expected linter behaviour in the presence of namespace aliases.
This pull request doesn't change the script's behaviour with respect to namespace aliases. They were marked as violations before and they are marked as violations with this new implementation too. I added an additional case in the regression test to confirm this. If we want to explicitly handle or document namespace aliases, I thus suggest to do it in a separate pull request. |
OK, makes sense. Thanks for adding the extra test case. |
Done. |
Only give warnings for namespaces with actual names, in accordance with
ad41375.
This enables the use of anonymous namespaces without warnings.