Replace TravisCI with Github Actions #153
Conversation
Signed-off-by: František Nečas <[email protected]>
|
Hm, it's weird that there are no Github Actions checks on this pull request. Not sure if it has to be enabled somewhere (the checks seem to be running on my branch - see https://github.com/FrNecas/2ls/runs/3381779235 ) |
| build: | ||
| strategy: | ||
| matrix: | ||
| os: [ubuntu-latest] |
There was a problem hiding this comment.
I would have liked to include os: [ubuntu-latest, macos-latest] but the build fails on mac for a weird reason. See https://github.com/FrNecas/2ls/runs/3381425349#step:3:196 :
In file included from xml_parser.cpp:13:
In file included from /Applications/Xcode_12.4.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/fstream:188:
In file included from /Applications/Xcode_12.4.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/filesystem:240:
/Applications/Xcode_12.4.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/stack:127:5: error: expected ')'
stack()
^
../util/parser.h:144:25: note: expanded from macro 'stack'
#define stack(x) (PARSER.stack[x])
^
/Applications/Xcode_12.4.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/stack:127:5: note: to match this '('
../util/parser.h:144:18: note: expanded from macro 'stack'
#define stack(x) (PARSER.stack[x])
^
That looks like fstream include fails due to some problem in the C++ library on Mac while CBMC is being compiled? I can't reproduce, test or debug it since I don't have a mac :/ So I put only Ubuntu there for now.
|
Github actions always execute the workflow defined on the default branch. Otherwise, anyone can create a PR with a workflow and run anything. |
|
Is this ready to merge? |
|
I'd say so unless we can somehow figure out what's wrong with the mac build. Or lets phrase it differently - are we fine with testing just under Ubuntu? Previously we tested on mac as well so this slightly reduces the robustness of our CI. I just don't know what's wrong with the build, the CBMC compilation fails ( see the trace #153 (comment) ). It looks like |
|
We can debug the mac issue separately. |
|
The linter job seems to have a problem. The ubuntu jobs work correctly. Tests are run and pass. |
|
Yes, the problem occurrs only when the action is ran after pushing (merging in this case) to the master branch as it refuses to fetch - fixed here #154 |
Since TravisCI is no longer free, we agreed with @viktormalik to migrate to Github Actions for CI purposes.