Skip to content

Update to CBMC 5.11 #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 1, 2021
Merged

Conversation

FrNecas
Copy link
Contributor

@FrNecas FrNecas commented Apr 29, 2021

2 releases at once this time, since 5.10 required only a small test change (see the commit). The next release is probably going to be tough...

CBMC 5.11 most important changes:

  • abstract interpretation changes, transform now takes function name, operator() as well. This required changing the passed arguments to various objects/methods in a lot of places
  • output method removed from various objects, e.g. from goto_modelt, replaced with show_goto_functions function
  • lhs_object has been removed from goto_step_tracet, I am not very confident about my fix in b35aedb ...
  • pointer_offset_size now returns std::optional

Related: peterschrammel/cbmc#24

Copy link
Collaborator

@viktormalik viktormalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a small naming nit.

@FrNecas FrNecas force-pushed the frnecas-cbmc-5.11 branch from b4fe4e8 to fc33f52 Compare April 29, 2021 17:14
Copy link
Member

@peterschrammel peterschrammel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please update the submodule and merge.

FrNecas added 2 commits May 1, 2021 12:01
Update expected assertion descriptions (5.10 change)
 - During analyses of code such as `p->n`, CBMC now creates an assertion that
   takes the offset of `n` into consideration leading to a different
   assertion description. Moreover, a new type of check has been added
   leading to a shift in numbering
Adjust domains transform() arguments
Adjust to operator() changes in domains
Fix function_application_exprt construction
Consider optional return value of pointer_offset_size
Fix constant_propagator_ait construction
Remove setting of lhs_object in goto_trace_stept
 - The API of the class has changed, the whole lhs_object is no longer
   stored there, however it can be obtained using get_lhs_object method
   which uses full_lhs to parse it.
Fix goto program loading
Fix show_symbol_table call
Fix GOTO program output
Fix show_goto_trace call

Signed-off-by: František Nečas <[email protected]>
Signed-off-by: František Nečas <[email protected]>
@FrNecas FrNecas force-pushed the frnecas-cbmc-5.11 branch from fc33f52 to d7ec9e3 Compare May 1, 2021 10:18
@FrNecas
Copy link
Contributor Author

FrNecas commented May 1, 2021

Should be ready for merge once the tests pass

@peterschrammel peterschrammel merged commit 9c5d5e5 into diffblue:master May 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants