Do not use mem::transmute on non #[repr(C)] structs
#1429
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgrif
approved these changes
Dec 20, 2017
|
Can you please update your commit message to include a link to rust-lang/rust#44890 as context? |
Neither PgConnection nor PgMetadataLookup are marked as `#[repr(C)]` so this is at least implemetation defined behaviour. (The implementation of `std::path::Path` changed in rust-lang/rust#44890)
weiznich
force-pushed
the
bugfix/fix_pg_metadata_lookup
branch
from
eb97d8f to
25b07c4
Compare
Done |
|
Feel free to merge when CI is green |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Neither PgConnection nor PgMetadataLookup are marked as
#[repr(C)]sothis is at least implemetation defined behaviour.
(The implementation of
std::path::Pathalso changed)