Skip to content

feat(time-picker): support minuteStep rule #252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 17, 2018
Merged

Conversation

AmyFoxFN
Copy link
Contributor

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow DiDi's contributing guide.
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer relative issues for you PR.

@codecov-io
Copy link

codecov-io commented Jul 17, 2018

Codecov Report

Merging #252 into dev will decrease coverage by 0.04%.
The diff coverage is 86.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #252      +/-   ##
==========================================
- Coverage   93.02%   92.97%   -0.05%     
==========================================
  Files         131      131              
  Lines        2780     2791      +11     
  Branches      416      419       +3     
==========================================
+ Hits         2586     2595       +9     
- Misses         97       98       +1     
- Partials       97       98       +1
Impacted Files Coverage Δ
src/components/time-picker/time-picker.vue 88.88% <86.66%> (-1.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a059568...1b3b16a. Read the comment docs.

@AmyFoxFN AmyFoxFN merged commit 7532b40 into dev Jul 17, 2018
@AmyFoxFN AmyFoxFN deleted the feat-time-picker-delay branch July 31, 2018 07:18
hu0950 pushed a commit that referenced this pull request Nov 1, 2019
* feat: minute step rule

* docs: chinese

* fix: number value

* test: minuteStep

* docs: update

* fix: min hour change caused by ceil

* test: add case
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants