chore(tests): avoid calling os.Exit in TestMain#8765
Merged
mangalaman93 merged 1 commit intomainfrom Mar 20, 2023
Merged
Conversation
we should not call os.Exit in TestMain any more. Calling os.Exit would not cleanup after the test run ever when all the tests run fine. For more details, see * https://pkg.go.dev/testing#hdr-Main * https://go-review.googlesource.com/c/go/+/219639
mangalaman93
requested review from
MichelDiz,
akon-dey,
billprovince,
darkn3rd,
matthewmcneely,
meghalims and
skrdgraph
as code owners
ghost
added
area/core
all-seeing-code
approved these changes
Mar 20, 2023
shivaji-kharse
approved these changes
Mar 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
we should not call os.Exit in TestMain any more. Calling os.Exit would not cleanup after the test run ever when all the tests run fine. For more details, see