chore(linter): fix some of the warnings from gas linter#8664
Merged
mangalaman93 merged 1 commit intomainfrom Feb 15, 2023
Merged
chore(linter): fix some of the warnings from gas linter#8664mangalaman93 merged 1 commit intomainfrom
mangalaman93 merged 1 commit intomainfrom
Conversation
4d9dce8 to
9800210
Compare
c93bbb0 to
6f4b264
Compare
Contributor
|
@mangalaman93 Can you add what's gas linter (probably a link as well)? |
9800210 to
77b329d
Compare
6f4b264 to
00cf4c3
Compare
d7484b1 to
a662e0d
Compare
00cf4c3 to
3bc53e8
Compare
a662e0d to
4b08ae4
Compare
01fbbf5 to
3bc53e8
Compare
a187cdb to
af3e142
Compare
Contributor
@anurags92 this explains all linters https://golangci-lint.run/usage/linters/ (I recommend spending about 15mins doing a high level reading) & compare with our Also this was something I had bookmarked https://github.com/golangci/awesome-go-linters (may have deprecated linters). |
skrdgraph
previously approved these changes
Feb 15, 2023
af3e142 to
3ab751d
Compare
Contributor
Author
|
Thanks Sudhish, yeah, will need to keep an eye out. I didn't see anything interesting during my testing locally on the laptop. |
all-seeing-code
previously approved these changes
Feb 15, 2023
3ab751d to
981e99d
Compare
all-seeing-code
approved these changes
Feb 15, 2023
ghost
approved these changes
Feb 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this is the linter https://github.com/securego/gosec