fix(test): fix the corner case for raft entries test#8617
Merged
mangalaman93 merged 1 commit intomainfrom Jan 20, 2023
Merged
Conversation
sanjayk-github-dev
previously approved these changes
Jan 19, 2023
Contributor
sanjayk-github-dev
left a comment
There was a problem hiding this comment.
Looks good to me
all-seeing-code
previously approved these changes
Jan 19, 2023
b777644
f215457 to
b777644
Compare
all-seeing-code
approved these changes
Jan 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A failure here: https://github.com/dgraph-io/dgraph/actions/runs/3952517043/jobs/6767694064
This happens when the length of data byte slice is 0. I do not think that is a valid case.