fix(tests): Added Backup/Restore test for NFS.#8551
Merged
shivaji-kharse merged 31 commits intomainfrom Feb 1, 2023
Merged
Conversation
shivaji-kharse
requested review from
akon-dey,
billprovince,
darkn3rd,
matthewmcneely,
meghalims and
skrdgraph
as code owners
github-actions
Bot
added
area/integrations
skrdgraph
changed the title
|
|
Contributor
|
this is a
ToDo:
Future Changes needed:
This PR should NOT be merged till we do some more cleanups. |
Contributor
|
@shivaji-dgraph will fix up the ci-yaml file - because there are py dependencies and other dependencies as you had shown during the call. So once you fix those up, this PR tests should all pass. Post a successful run, we shall start looking into the |
mangalaman93
requested changes
Jan 3, 2023
Contributor
mangalaman93
left a comment
mangalaman93
left a comment
There was a problem hiding this comment.
These are some really useful tests but we need to improve the tests. I have added a few comments and I can help more if you get stuck. Please take a look.
Contributor
|
Please rebase the change on latest main and force push before we can review it. Thanks |
shivaji-kharse
force-pushed
the
backup-systest
branch
2 times, most recently
from
e8bc42f to
561ca0c
Compare
shivaji-kharse
changed the title
mangalaman93
requested changes
Jan 11, 2023
mangalaman93
requested changes
Jan 12, 2023
shivaji-kharse
force-pushed
the
backup-systest
branch
from
b2b758d to
09aa050
Compare
Contributor
all-seeing-code
left a comment
all-seeing-code
left a comment
There was a problem hiding this comment.
Please update the description with information on what scenario is being tested.
Contributor
This needs more details. |
all-seeing-code
previously approved these changes
Jan 16, 2023
…age and resolved review comments
shivaji-kharse
force-pushed
the
backup-systest
branch
from
9ba24ef to
a0cde5a
Compare
mangalaman93
approved these changes
Jan 31, 2023
matthewmcneely
approved these changes
Jan 31, 2023
all-seeing-code
approved these changes
Feb 1, 2023
mangalaman93
added a commit
that referenced
this pull request
Feb 6, 2023
This reverts commit 9739415. It is failing on CI.
all-seeing-code
pushed a commit
that referenced
this pull request
Feb 8, 2023
Change: Added new automated tests for backup/restore (full as well as incremental ) on NFS. Test Scenarios covered:- - Full+Incremental backup on nfs mounted directory - Full+Incremental restore from nfs mounted directory.
all-seeing-code
pushed a commit
that referenced
this pull request
Feb 8, 2023
Change: Added new automated tests for backup/restore (full as well as incremental ) on NFS. Test Scenarios covered:- - Full+Incremental backup on nfs mounted directory - Full+Incremental restore from nfs mounted directory.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change: Added new automated tests for backup/restore (full as well as incremental ) on NFS.
Test Scenarios covered:-