chore: Unit test coverage lex/iri.go,chunker/chunk.go#8515
Merged
mangalaman93 merged 8 commits intomainfrom Jan 10, 2023
Merged
chore: Unit test coverage lex/iri.go,chunker/chunk.go#8515mangalaman93 merged 8 commits intomainfrom
mangalaman93 merged 8 commits intomainfrom
Conversation
ghost
requested review from
akon-dey,
billprovince,
darkn3rd,
gcxml,
matthewmcneely,
meghalims and
skrdgraph
as code owners
|
|
matthewmcneely
requested changes
Dec 15, 2022
Contributor
|
@shivaji-kumowiz There is still this oddly formatted function in there... the blank lines on 286 & 289
|
matthewmcneely
approved these changes
Dec 17, 2022
mangalaman93
requested changes
Jan 5, 2023
mangalaman93
requested changes
Jan 9, 2023
Contributor
mangalaman93
left a comment
mangalaman93
left a comment
There was a problem hiding this comment.
one more suggestion, looks good otherwise.
Added missing files for previous commit
shivaji-kharse
force-pushed
the
coverage_lex_iri
branch
from
e06d831 to
44e1aa3
Compare
mangalaman93
reviewed
Jan 9, 2023
mangalaman93
approved these changes
Jan 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unit Tests written for:-
Package name:- chunker
File covered:- chunk.go
Functions covered:-
1] (*rdfChunker) Chunk()
Package name:- lex
File covered:- iri.go
Functions covered:-
1]isIRIRefChar()
2]HasUChars()
3]HasXChars()
4]isHex()