chore: Unit test coverage x/file.go,chunker/chunk.go#8489
Merged
Conversation
shivaji-kharse
requested review from
akon-dey,
billprovince,
darkn3rd,
gcxml,
matthewmcneely,
meghalims and
skrdgraph
as code owners
|
|
matthewmcneely
approved these changes
Dec 6, 2022
meghalims
approved these changes
Dec 12, 2022
Contributor
meghalims
left a comment
meghalims
left a comment
There was a problem hiding this comment.
Looks good. Please squash-merge
all-seeing-code
pushed a commit
that referenced
this pull request
Dec 14, 2022
**Unit Tests written for**:- **Package name**:- chunker **File covered**:- chunk.go **Functions covered**:- 1] FileReader() 2] DataFormat() **Package name**:- x **File covered**:- file.go **Functions covered**:- 1]IsMissingOrEmptyDir() 2]FindDataFiles()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unit Tests written for:-
Package name:- chunker
File covered:- chunk.go
Functions covered:-
1] FileReader()
2] DataFormat()
Package name:- x
File covered:- file.go
Functions covered:-
1]IsMissingOrEmptyDir()
2]FindDataFiles()